libc: minimal: sys/types.h: move mem_word_t to string.c #97411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfriedt
force-pushed
the
drop-sys-types-from-minimal-memset
branch
from
e1efb17 to
70512a4
Compare
|
zephyrbot
requested review from
aescolar,
keith-packard,
nashif and
stephanosio
8 tasks
npitre
reviewed
Oct 14, 2025
The `sys/types.h` header is part of POSIX, which is optional in Zephyr and is mostly unimplemented by Zephyr's minimal C library. Additionally, the only reason `sys/types.h` is included in `string.c` (in the minimal libc) is because of the non-standard `mem_word_t` type. `mem_word_t` is not used anywhere else in-tree or in modules hosted by the Zephyr project. It is only used in `string.c` in the minimal c library. It's definitely not specified here https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/sys_types.h.html and so does not really belong in `sys/types.h`. Move `mem_word_t` into the minimal libc's `string.c`. If needed, it can be removed at a later date and switched for `uintptr_t`. Signed-off-by: Chris Friedt <[email protected]>
cfriedt
force-pushed
the
drop-sys-types-from-minimal-memset
branch
from
70512a4 to
5d5782d
Compare
cfriedt
changed the title
|
@npitre - fixed! |
|
npitre
approved these changes
Oct 14, 2025
ycsin
approved these changes
Oct 14, 2025
stephanosio
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
sys/types.hheader is part of POSIX, which is optional in Zephyr and is mostly unimplemented by Zephyr's minimal C library.Additionally, the only reason
sys/types.his included instring.c(in the minimal libc) is because of the non-standardmem_word_ttype.mem_word_tis not used anywhere else in-tree or in modules hosted by the Zephyr project. It is only used instring.cin the minimal c library.It's definitely not specified here https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/sys_types.h.html and so does not really belong in
sys/types.h.Move
mem_word_tinto the minimal libc'sstring.c. If needed, it can be removed at a later date and switched foruintptr_t.